search

cine-io / cineio-broadcast-android

The cine.io Android Broadcast SDK
https://www.cine.io/products/broadcast
MIT License
52 stars 32 forks source link

Custom width and height #4

Closed trshafer closed 9 years ago

trshafer commented 9 years ago

@lgorse what do you think about this PR for custom width and heights. Due to the camera requirements, the width and height must be landscape values, but it can translate to portrait. Meaning the camera can only open in 640x480 and not 480x640. But when the camera is rotated to portrait, it acts as 480x640, if that makes sense.

trshafer commented 9 years ago

just added orientation lock.

trshafer commented 9 years ago

Added camera selection.

cine-dev commented 9 years ago

Ok. I'll merge this in today.

On Fri, Jan 16, 2015 at 2:38 AM, lgorse notifications@github.com wrote:

Hey Work kept me really late today (just getting out) but tomorrow evening I can have a look - sorry for delay. Obvs don't wait for me if you want to release before the weekend.

On Thu, Jan 15, 2015 at 1:30 PM, Thomas Shafer notifications@github.com wrote:

@lgorse https://github.com/lgorse what do you think about this PR for custom width and heights. Due to the camera requirements, the width and height must be landscape values, but it can translate to portrait. Meaning the camera can only open in 640x480 and not 480x640. But when the camera is

rotated to portrait, it acts as 480x640, if that makes sense.

You can merge this Pull Request by running

git pull https://github.com/cine-io/cineio-broadcast-android custom-width-and-height

Or view, comment on, or merge it at:

https://github.com/cine-io/cineio-broadcast-android/pull/4 Commit Summary

  • allow for custom width and height
  • Include example of broadcasting with a custom width/height

File Changes

  • M

CineIOExampleApp/src/main/java/io/cine/example/CineIoStreamViewActivity.java

https://github.com/cine-io/cineio-broadcast-android/pull/4/files#diff-0

(7)

(12)

  • M

cineio-broadcast-android-sdk/src/main/java/io/cine/android/BroadcastActivity.java

https://github.com/cine-io/cineio-broadcast-android/pull/4/files#diff-2

(12)

  • M

cineio-broadcast-android-sdk/src/main/java/io/cine/android/CineIoClient.java

https://github.com/cine-io/cineio-broadcast-android/pull/4/files#diff-3

(21)

  • M

cineio-broadcast-android-sdk/src/main/java/io/cine/android/streaming/EncodingConfig.java

https://github.com/cine-io/cineio-broadcast-android/pull/4/files#diff-4

(42)

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/cine-io/cineio-broadcast-android/pull/4.

Laurent Gorse MBA, class of 2013 Stanford Graduate School of Business 650.644.9188 lgorse@stanford.edu gsb.stanford.edu|Facebook: StanfordGSB http://facebook.com/StanfordGSB |Twitter: @StanfordBiz http://twitter.com/StanfordBiz

— Reply to this email directly or view it on GitHub https://github.com/cine-io/cineio-broadcast-android/pull/4#issuecomment-70236194 .