cine-io / cineio-broadcast-android

The cine.io Android Broadcast SDK
https://www.cine.io/products/broadcast
MIT License
52 stars 32 forks source link

Allow the client to customize the BroadcastActivity #8

Closed lgorse closed 9 years ago

lgorse commented 9 years ago

Problem: it was difficult to customize BroadcastActivity before. Assume for instance i want a custom button on the view. I'd have to edit my own version of the activity, which is not ideal given the constant updates to the class.

Instead I'd rather:

This ensures that I can now extend BroadcastActivity to suit my needs as a client. After all, my goal as a developer is to create my own broadcasting view easily.

NOTE:

I guess theres a lot of proposals in this repo so I'm curious to see if any of it is useful. I had initially created extensions to BroadcastConfig and CineIoClient to suit my needs, then realized a couple of lines of code could do the same.

I'll bet not all of this is useful - curious to hear how you guys feel about it.

Oh and watch out - I don't have my head around add --patch yet and so my gradle file may not match yours.

NOTE: my last commit remove the merge wrapper and restored relative layout. Any client that wants to use the API should be able to copy/paste the relevant elements in his custom BroadcastActivity XML.

trshafer commented 9 years ago

I like this a lot. I would love to have a broadcast activity that is much more customizable. This is a great step in that direction. I'll merge it in. Thank you @lgorse!

lgorse commented 9 years ago

No worries! I love your API, you're taking care of the hard stuff and letting me play with the consumer-facing stuff, so thank you.