search

cinecert / asdcplib

AS-DCP and AS-02 File Access Library
Other
73 stars 55 forks source link

wrapping ST 428-7 fails when wrapping more than 1516 PNG files #76

Open dcbullock opened 3 years ago

dcbullock commented 3 years ago

The count of resources (1516) was determined experimentally and may not be exact.

dcbullock commented 3 years ago

Issue in src/AC_DCP_TimedText.cpp

The calculation to increase the header buffer size contract (m_HeaderSize) is incorrect. Because the default m_HeaderSize is 16384, this is not an issue for smaller sets of PNG files.

src/AS_DCP_TimedText.cpp ASDCP::TimedText::MXFWriter::h__Writer::SetSourceStream

The growth constant, 72, is too small. With a large enough set of sub-descriptors, m_HeaderSize will be too small to write out the header.

stephw999 commented 3 years ago

with 2.10.39 (compiled with openssl 1.1.1k and Xerces-C 3.2.3) I have wrapped 1744 png in a smpte MXF file. Not yet tested on a server. Best regards. Stéphane.W