cinecert / asdcplib

AS-DCP and AS-02 File Access Library
Other
73 stars 55 forks source link

Integrate support for JPEG XS according to ST2124 #81

Closed thorfdbg closed 3 years ago

thorfdbg commented 3 years ago

John,

please kindly review the attached pull request from Fraunhofer IIS Germany. This branch enables JPEG XS support (ISO/IEC 21122-1) in libasdcp, following SMPTE ST 2124.

Best regards,

Thomas Richter

jhursty commented 3 years ago

This is a well organized and comprehensive request. Thank you.

The scope is wider than I would have expected, what is the expectation behind the AS-DCP wrappers? I am concerned that adding them to the main branch will promote confusion among users that should not be using these options (i.e., unintentional deployment.) Perhaps those features should live in a branch if they are not yet part of any production pipeline.

I'd also like to see additional proponents for this work. We should have at least two unrelated parties with actual intent to interchange between them. The first step for any proponent is to review the request and post here.

thorfdbg commented 3 years ago

John,

the expectation here is to implement the latest SMTE specs that define how to wrap JPEG XS in ASDCP and AS02 - thus, I wouldn't say that we are proposing a particular wrapping, but rather implement the documented specifications. For example, the URNs you see in the sources were all taken from SMPTE.

I can certainly provide more details on the origin of the wrapping and the precise specifications, though github is probably not the right place to discuss and we should carry this out over email: thomas dot richter at iis-fraunhofer dot de.

Thanks,

Thomas