search

cinecert / asdcplib

AS-DCP and AS-02 File Access Library
Other
70 stars 54 forks source link

Fixed constructor of JXS file reader. #99

Closed thorfdbg closed 2 years ago

thorfdbg commented 2 years ago

Hi John,

one of your latest commits changed the constructor of the MXFReader, requiring an additional argument. Apparently, this was not adjusted for the JXS support, so the code no longer built. This pull request fixes the issue.

For some reason, the make rules also seem to depend on src/CRC16.c src/SyncEncoder.c src/UUIDInformation.c (not .cpp) which (as C source rather than C++ source) do not exist. While I haven't checked, there is probably something wrong with the automake rules defining them as C rather C++? Could you please check.

Thanks, Thomas

ArnaudBienner commented 2 years ago

@thorfdbg sorry: this was introduced by a recent change we contributed recently to the asdcplib.

I implemented #100 to prevent someone to accidentally break JXS support in the future without noticing.

As for autoconf and the files renamed from .c to .cpp, this was already fixed but I've found that locally, autoconf caches some values and would always consider the old filenames.

IIRC I needed to remove the .deps folder created by autoconf under src/ and rerun autoconf again.

Hope that helps.

jhursty commented 2 years ago

make distclean to remove stale deps