search

cinely / mule-uploader

Stubborn HTML5 Amazon S3 uploader
http://mule-uploader.com/
MIT License
223 stars 43 forks source link

Update mule-uploader.js #22

Closed couresel closed 9 years ago

couresel commented 10 years ago

I did not see that settings.extra_params was being incorporated in the query_string sent to ./signing_key/ and ./chunk_upload/.

Given that the variable exists and is not used by any resource in the code, I assume the intent was to allow the user to describe additional parameters to be passed in with this above request and made some mods to allow for that.

gabipurcaru commented 9 years ago

Well, to be honest, I can't exactly remember what I had in mind when I put that in there, but I now see no use of it (and nobody requested this feature), so I guess I'll close your PR. I'm really sorry for your wasted work.

couresel commented 9 years ago

For what it's worth, I use this feature =/

I wouldn't consider it wasted. Great plugin, well written. I made a small extension to fit it into our project needs with having to write the entire product so thank you for producing and sharing this. On Dec 21, 2014 12:48 PM, "Gabi Purcaru" notifications@github.com wrote:

Well, to be honest, I can't exactly remember what I had in mind when I put that in there, but I now see no use of it (and nobody requested this feature), so I guess I'll close your PR. I'm really sorry for your wasted work.

— Reply to this email directly or view it on GitHub https://github.com/cinely/mule-uploader/pull/22#issuecomment-67778081.

gabipurcaru commented 9 years ago

If this is the case, let's implement this :) I'll have to test this and make sure everything works alright, and then I'll merge it.

couresel commented 9 years ago

Please do. Let me know if I need to correct anything. We've been using it in production for 6 months. On Dec 21, 2014 2:51 PM, "Gabi Purcaru" notifications@github.com wrote:

If this is the case, let's implement this :) I'll have to test this and make sure everything works alright, and then I'll merge it.

— Reply to this email directly or view it on GitHub https://github.com/cinely/mule-uploader/pull/22#issuecomment-67782117.

gabipurcaru commented 9 years ago

Just landed this on master after a bit of cleanup. Thanks for the help!

couresel commented 9 years ago

Thank you. On Feb 15, 2015 3:28 AM, "Gabi Purcaru" notifications@github.com wrote:

Just landed this on master after a bit of cleanup. Thanks for the help!

— Reply to this email directly or view it on GitHub https://github.com/cinely/mule-uploader/pull/22#issuecomment-74408757.