cinema6 / minireelinator

0 stars 1 forks source link

Open sign up form in a modal #1315

Closed dhavaljani closed 8 years ago

dhavaljani commented 8 years ago

"Get Started Now" button should open the sign up form in a modal for desktop users and show /signup/form in the modal

sqmunson commented 8 years ago

@dhavaljani Where is this "Get Started Now" button?

dhavaljani commented 8 years ago

It's on the preview page https://platform-staging.reelcontent.com/#/demo/frame/preview?email=false&ref=ilsf2h7ytk&promotion=pro-0gW6Qt03q32WqsC-

sqmunson commented 8 years ago

And that's better than going to sign up page like we do now?

dhavaljani commented 8 years ago

It would be less cluttered/distracting than our current sign up form and there won't be a disconnect between the page that says sign up to get $50 or X and would be consistent with other sign up modals on landing page - https://reelcontent.com/landing-page/great-place-to-visit.html?ref=ilsf2h7ytk&promotion=pro-0gW6Qt03q32WqsC-

sqmunson commented 8 years ago

Alright. Well, @ScottBouloutian, we want to keep this nice and DRY. The quick and dirty solution would be to add a modal with the sign up form in an iframe. The nicer solution would be to reuse the same sign up state and logic but to load in an alternate template for this new alias of the sign up state. The alternate template would have modal html wrapping an ng-include of the sign up template.

sqmunson commented 8 years ago

@dhavaljani What happens on mobile if they click the button?

dhavaljani commented 8 years ago

@sqmunson On mobile, it already redirects to signup/form and it looks fine.