search

cinema6 / rumble

Rumble Interactive
0 stars 0 forks source link

Mobile DisplayAds Need Styles #686

Closed minznerjosh closed 9 years ago

minznerjosh commented 9 years ago

to @turtlemonster

To see the ad:

  1. git checkout josh__add-mobile-display-ad-support
  2. On phone, open first experience in experiences.json
  3. Go to JCVD FTW sponsored card
  4. Wait for video to finish playing
turtlemonster commented 9 years ago

@minznerjosh this seems styled already. Nothing stands out that looks "unstyled". What I do see is a big gap between the title of the card and the display ad itself. This is because the video thumbnail div is still being displayed, but without the thumbnail itself, so you get a lot of white space before the display ad.

Can we hide the player__thumbnail div when the display ad is meant to be shown?

turtlemonster commented 9 years ago

@minznerjosh btw, in landscape view, the video player does not disappear at all after the video. So you see the video, the large white space, and then the ad.

minznerjosh commented 9 years ago

@turtlemonster Updated so that player__thumbnail is hidden when the display ad is shown

Regarding the video not disappearing in landscape, the player--fly-away class is getting added. Seems like a CSS bug to me.

turtlemonster commented 9 years ago

@minznerjosh how DARE you?!? Haha. I will take a look. Thanks.

minznerjosh commented 9 years ago

@turtlemonster Haha Thanks!

turtlemonster commented 9 years ago

@minznerjosh fixed