search

cinemascience / cinema_scope

A simple cross platform viewer for image-based databases
Other
2 stars 2 forks source link

Non-integer time steps not properly handled #47

Open terryturton opened 4 years ago

terryturton commented 4 years ago

CinemaScope is not properly handling non-integer time steps. To reproduce:

dhrogers commented 4 years ago

Problem was a general issue with values having more than 6 digits of decimal precision. Should be fixed now.

terryturton commented 4 years ago

Previous solution may not be sufficient. A data.csv with 0 to 29 was read as 0,1,10,11,12,13,14,15,16,17,18,19,2,20,21,... etc. May need an additional sort or choose between casting as int or keeping as string based on time step nomenclature.

dhrogers commented 4 years ago

Ack.

Will look at this.

D

Sent with BlackBerry Work (www.blackberry.com)

From: Terry Turton notifications@github.com<mailto:notifications@github.com> Date: Thursday, Feb 13, 2020, 11:27 AM To: cinemascience/cinema_scope cinema_scope@noreply.github.com<mailto:cinema_scope@noreply.github.com> Cc: Rogers, David Honegger dhr@lanl.gov<mailto:dhr@lanl.gov>, State change state_change@noreply.github.com<mailto:state_change@noreply.github.com> Subject: [EXTERNAL] Re: [cinemascience/cinema_scope] Non-integer time steps not properly handled (#47)

Previous solution may not be sufficient. A data.csv with 0 to 29 was read as 0,1,10,11,12,13,14,15,16,17,18,19,2,20,21,... etc. May need an additional sort or choose between casting as int or keeping as string based on time step nomenclature.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/cinemascience/cinema_scope/issues/47?email_source=notifications&email_token=ABIX4AF5PMNIUF7RZD6RNHDRCVYH3A5CNFSM4KKYKPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELVUUBQ#issuecomment-585845254, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIX4AFNPCTVLFUF2JCTDHTRCVYH3ANCNFSM4KKYKPFQ.