search

cinemataztic / cine-ui

0 stars 0 forks source link

File upload component #25

Closed alkiko closed 2 years ago

alkiko commented 2 years ago

Is your feature request related to a problem? Please describe. It's inefficient to have to build and style a file upload component separately for each implementation.

Describe the solution you'd like A generic file upload component in the cine-ui theme.

Describe alternatives you've considered Not including it in the component library and building it in each consumer project. I think it's better to include it.

Additional context Example of the design and how it's used in the CineAd Tradedesk to upload video files to spots.

Upload

Create campaign

alkiko commented 2 years ago

We're using https://github.com/react-dropzone/react-dropzone at cloud.cinemataztic.com. It has worked fine so far (several years). I haven't looked in to other implementations since.

MikkelWestermann commented 2 years ago

As we've spoken about, the text colors currently are primary and default (and inverted), but which color is the text in the FileUpload? It doesn't really fit either one. My suggestion would be to have a color called default-muted for this case. Thoughts, @alkiko?

alkiko commented 2 years ago

@pixochi added a text color variation called defaultSubtle in https://github.com/cinemataztic/cine-ui/pull/33#pullrequestreview-873619151. I suggest using defaultSubtle here too.

MikkelWestermann commented 2 years ago

Okay, cool