search

cinemataztic / cine-ui

0 stars 0 forks source link

Spinner component #47

Closed MikkelWestermann closed 2 years ago

MikkelWestermann commented 2 years ago

I took your unanimous 👍 reaction as agreement with the need for a loading indicator.

MikkelWestermann commented 2 years ago

Looks good. Same comments as @sandhana14.

Also, it seems as if there's some margin or padding causing the spinner not to be completely centered when it's spinning. See video:

Screen.Recording.2022-02-23.at.12.35.53.mov

Ahh, what?? Very steady here...

https://user-images.githubusercontent.com/39190490/155394925-6fa4717a-22ab-494f-91d6-f25a6bd18a89.mov

alkiko commented 2 years ago

Looks good. Same comments as @sandhana14. Also, it seems as if there's some margin or padding causing the spinner not to be completely centered when it's spinning. See video: Screen.Recording.2022-02-23.at.12.35.53.mov

Ahh, what?? Very steady here...

Screen.Recording.2022-02-23.at.20.33.22.mov

Seems to be a Safari issue. Steady in Chrome and Firefox.

https://user-images.githubusercontent.com/6972570/155591013-85b6eda0-2374-4ae2-90ba-3e1a26485370.mov