search

cinemataztic / cine-ui

0 stars 0 forks source link

Button: add states (hover, click etc.), limit to sm + lg sizes #5

Closed sandhana14 closed 2 years ago

sandhana14 commented 2 years ago

…d made changes based on the feedback

sandhana14 commented 2 years ago

Bit confused about the button size options, as there's only two sizes in the design:

  • 36px (same as "sm" in our implementation)
  • 48px (doesn't exist in our design)

48px seems to be the deafult size in the design - we need to add that one to our design.

Is there a reason for having this many sizes in our UI library?

Bit confused about the button size options, as there's only two sizes in the design:

  • 36px (same as "sm" in our implementation)
  • 48px (doesn't exist in our design)

48px seems to be the deafult size in the design - we need to add that one to our design.

Is there a reason for having this many sizes in our UI library?

I'll add 48px to our implementation. The reason for having many sizes is, I thought to give as many customizable options as possible and I referred Chakra UI components.