search

cinemataztic / cine-ui

0 stars 0 forks source link

Made changes based on the feedback #6

Closed sandhana14 closed 2 years ago

sandhana14 commented 2 years ago

Storybook prints: "This story is not configured to handle controls. Learn how to add controls". Is that intentional? Screenshot 2022-01-04 at 11 45 53

Yes, I didn't add controls because most of the props are onChange function and states. That is the reason I thought, it is not necessary.

alkiko commented 2 years ago

I've added another PR (#12) @sandhana14 and @pixochi with atomic checkboxes. If we decide to go with #12 we need to decide if this implementation should be skipped or included as a separate checkboxes or checkbox-panel component.

pixochi commented 2 years ago

I've added another PR (#12) @sandhana14 and @pixochi with atomic checkboxes.

I think that a single checkbox is enough.