cinnyapp / cinny-desktop

Yet another matrix client for desktop
GNU Affero General Public License v3.0
415 stars 49 forks source link

Add ctrl+q and prepare ctrl+w keybinds #205

Open hugeblank opened 1 year ago

hugeblank commented 1 year ago

Description

Fixes #204

Lifts event handler logic from paste image support (#167).

Includes some commented out logic for compatibility with systray (#166) when/if merged. Requires TRAY_LABEL in tray.rs be exposed as public.

If I catch that the referenced PRs get merged before this one I'll resolve conflicts and uncomment code as necessary. That said, this PR on its own is ready to be merged if the maintainers want to handle the conflicts and changes I've mentioned.

Type of change

Checklist:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

hugeblank commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

hugeblank commented 1 year ago

recheck

hugeblank commented 1 year ago

Decided to build my PR and test it in production and it doesn't work. This threw me off because it worked in the dev environment. There's an open issue tracking the inability to set global shortcuts on wayland (tauri-apps/tauri#3578), and I think that's the issue now. Guess this PR is blocked until it gets fixed. Fun.