search

cinnyapp / cinny-desktop

Yet another matrix client for desktop
GNU Affero General Public License v3.0
417 stars 49 forks source link

Image download button does not save an image #211

Open Hydroidev opened 1 year ago

Hydroidev commented 1 year ago

Describe the bug

Download button for images does not work on desktop. Simply nothing happens in the interface and no file is downloaded to the default downloads directory as before (in version 2.2.6).

Reproduction

Starting from a fresh AppImage download and login:

  1. Find and click on an image to get the popup
  2. Click on the 'download' button
  3. Nothing happens and no download or file save is performed. Console logs a handful of issues (see below).

Expected behavior

Clicking the download button should cause the image to be saved to the file system.

Platform and versions

1. OS: Manjaro Linux (Kernel 6.3.13-2-MANJARO); KDE Plasma 5.27.8; X11; Qt 5.15.10  (also tested and reproduced on an Arch Linux computer)
2. Cinny version: 3.0.0 (AppImage)
3. Matrix homeserver: matrix.envs.net & kde.modular.im (tested and fails on both)
4. Downloaded from: [GitHub](https://github.com/cinnyapp/cinny-desktop/releases/download/v3.0.0/Cinny_desktop-x86_64.AppImage)

Additional context

Console logs the following four messages shortly after clicking the download button:

[Error] Failed to load resource: Origin tauri://localhost is not allowed by Access-Control-Allow-Origin. Status code: 405 (d2a8b3ec00f826aad488661fac7a77f14d37b53e1715716959313592320, line 0)
[Error] Origin tauri://localhost is not allowed by Access-Control-Allow-Origin. Status code: 405
    Q (index-e33ffa91.js:57111:5371)
    (anonymous function) (index-e33ffa91.js:57111:6191)
    r (index-e33ffa91.js:57142:67042)
    gz (index-e33ffa91.js:37:9307)
    Cz (index-e33ffa91.js:37:9461)
    Qz (index-e33ffa91.js:37:9518)
    nS (index-e33ffa91.js:37:28786)
    Ub (index-e33ffa91.js:37:29203)
    (anonymous function) (index-e33ffa91.js:37:34237)
    Db (index-e33ffa91.js:41:18348)
    Az (index-e33ffa91.js:37:8470)
    _b (index-e33ffa91.js:37:30610)
    Pp (index-e33ffa91.js:37:18203)
    Wp (index-e33ffa91.js:37:17779)
    Wp
    (anonymous function) (index-e33ffa91.js:26:3783)
    sb (index-e33ffa91.js:41:18206)
    wz (index-e33ffa91.js:37:17570)
    wz
[Error] XMLHttpRequest cannot load https://matrix.envs.net/_matrix/media/r0/download/t2bot.io/d2a8b3ec00f826aad488661fac7a77f14d37b53e1715716959313592320 due to access control checks.
    Q (index-e33ffa91.js:57111:5371)
    (anonymous function) (index-e33ffa91.js:57111:6191)
    r (index-e33ffa91.js:57142:67042)
    gz (index-e33ffa91.js:37:9307)
    Cz (index-e33ffa91.js:37:9461)
    Qz (index-e33ffa91.js:37:9518)
    nS (index-e33ffa91.js:37:28786)
    Ub (index-e33ffa91.js:37:29203)
    (anonymous function) (index-e33ffa91.js:37:34237)
    Db (index-e33ffa91.js:41:18348)
    Az (index-e33ffa91.js:37:8470)
    _b (index-e33ffa91.js:37:30610)
    Pp (index-e33ffa91.js:37:18203)
    Wp (index-e33ffa91.js:37:17779)
    Wp
    (anonymous function) (index-e33ffa91.js:26:3783)
    sb (index-e33ffa91.js:41:18206)
    wz (index-e33ffa91.js:37:17570)
    wz
[Warning] The download attribute on anchor was ignored because its href URL has a different security origin. (index-e33ffa91.js, line 57111)

The first two errors also occur when using https://app.cinny.in (version 3.0.0) but they do not impede download.