search

cinnyapp / cinny-desktop

Yet another matrix client for desktop
GNU Affero General Public License v3.0
360 stars 37 forks source link

No way to completely quit Cinny #218

Open Porkepix opened 8 months ago

Porkepix commented 8 months ago

Describe the bug

This is imho a bug as much as this is a feature request, so it might be requalified and you'll see this. Following latest Gnome update, there's no more menu offering to quit, and for all I know the result might have been the same as the one I describe below.

Reproduction

  1. "Quit" Cinny by clicking the cross
  2. See that you're still receiving desktop notifications
  3. Check processes and see that there are still Cinny processes running (and more than one!)

Expected behavior

While this behavior can be useful and wanted by users, offer a way to completely quit Cinny should also be possible. This is somehow a little bit linked to https://github.com/cinnyapp/cinny-desktop/issues/217 ; however some users would also need a graphical way to do so, outside of shortcuts.

Platform and versions

Linux & Gnome, Cinny 3.0

Additional context

No response

bengaywins commented 7 months ago

I don't see this issue on KDE. This is a Gnome issue since they killed the tray icons. It's in the tray now, but there's no option to change the behavior.

camelCaseNick commented 7 months ago

On modern GNOME (44+), you can close apps running in background from the quick settings menu, at least if they use the background Freedesktop portal, as e.g. the flatpaked Cinny uses. This menu is expected to be expanded, but not to provide the menus known from trays of other DEs. To unconditionally stop this behaviour of Cinny on tray-less systems is thus not a good idea. However, a solution could be seen in #236?

Porkepix commented 7 months ago

On modern GNOME (44+), you can close apps running in background from the quick settings menu, at least if they use the background Freedesktop portal, as e.g. the flatpaked Cinny uses. This menu is expected to be expanded, but not to provide the menus known from trays of other DEs. To unconditionally stop this behaviour of Cinny on tray-less systems is thus not a good idea. However, a solution could be seen in #236?

I'm not sure what quick settings menu are you referring to, but couldn't find anything. I don't use flatpaks, but https://aur.archlinux.org/packages/cinny-desktop ; could also be https://aur.archlinux.org/packages/cinny-desktop-bin or https://aur.archlinux.org/packages/cinny-web-git (though that one might be to host a Web application behind a Web server, looking at the name; didn't checked much).

I maintain that a way to do a full quit, be it through a shortcut as I was suggesting in #217 would be much better. It would avoid notifications to be marked as coming from some dead processes and I've recently seen strange behaviors where it could have some links but I'm absolutely not sure on that matter.

More generally, the absence of tray zone seems to lead to this kind of messages: cinny[3943357]: gtk_widget_get_scale_factor: assertion 'GTK_IS_WIDGET (widget)' failed; maybe this can be detected (catch the error/exception) from code and the feature disabled if it can't find any tray zone to set this?

8ullyMaguire commented 4 months ago

Related to #186 Customizable Minimize and Close Window Buttons