cinnyapp / cinny-desktop

Yet another matrix client for desktop
GNU Affero General Public License v3.0
415 stars 49 forks source link

Desktop app cannot request notification permission #360

Open nexy7574 opened 2 months ago

nexy7574 commented 2 months ago

Describe the bug

Pretty simple issue - open Cinny Desktop (v4.2.1), log in, navigate to user settings, notifications, and try to request notification permissions.

On the web app, this will prompt permission from the browser, and will then turn into a toggle. However, the desktop app appears to be a no-op - no error message logged, no acknowledgement of the button click

Reproduction

  1. Download Cinny Desktop (v4.2.1)
  2. Log in
  3. Navigate to user settings
  4. Navigate to Notifications
  5. Press "request permission"

Expected behavior

Permission is requested or given for the app to send notifications

Platform and versions

1. OS: Windows 11 Pro Education
2. Cinny: v4.2.1
3. Homeserver: nexy7574.co.uk
4. Downloaded from: GitHub releases

Additional context

Following up from a discussion in the matrix room

kfiven commented 1 month ago

From the discussion in matrix room, the notifications actually works, the only issue is the button that doesn't respond and no sound of notifications.