search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.79k stars 233 forks source link

Show a picture of a space or room if available #107

Open zarp-dev opened 2 years ago

zarp-dev commented 2 years ago

Is your feature request related to a problem? Please describe.

It is reasonable to make it so that if a room or space has a picture, the picture is displayed.

Describe the solution you'd like

Show a picture of the room (or space) if available, if not - show the default room (or space) icon Screenshot 2021-09-19 at 14 57 52

If the room does not have a picture, show the default room icon in the header: Screenshot 2021-09-19 at 23 43 54

kfiven commented 2 years ago

Blend of Pictures and Icons looks ugly as well as confusing. imho either we should keep all icons or all pictures.

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

Salamandar commented 2 years ago

Bump ! This is one of the few last things I prefer on Element ^^''

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

Uh… Maybe because pictures are here to recognize/differentiate multiple rooms ?

gabrc52 commented 1 year ago

Blend of Pictures and Icons looks ugly as well as confusing. imho either we should keep all icons or all pictures.

I agree but I would like this feature too, but the rooms in the proposed solution image dont look very clean to be honest. Spaces look great tho. This app has great design, which we don't want to break. Maybe all pictures (optional perhaps) would work

Also room icon is visible after opening the room so I don't get why we need to duplicate it in drawer.

What it would achieve: It gives you a birds eye view of the rooms you have. The room you're looking for catches your eye so you can click on it faster or find it faster.

Salamandar commented 1 year ago

Maybe all pictures (optional perhaps) would work

Yes, agreed. This could be a setting to let the user choose.

Salamandar commented 1 year ago

Blend of Pictures and Icons looks ugly as well as confusing.

…That's already what we have for people. Do you find Cinny ugly and confusing for that ?

Salamandar commented 1 year ago

I've wrote #1076 that successfully fixes this issue. It doesn't let the user choose though, maybe @kfiven would like to contribute a setting for this ?

kfiven commented 1 year ago

Blend of Pictures and Icons looks ugly as well as confusing.

…That's already what we have for people. Do you find Cinny ugly and confusing for that ?

I meant a blend of icons and pictures in one list. That's why I said either we should have icons or just pictures.

Salamandar commented 1 year ago

Yes, i understood. In the people list, you might have their avatar or a color circle with a letter if they don't have an avatar. So we already have mixed display in Cinny.

belkka commented 7 months ago

I'll duplicate what I wrote in #1076:

Today I came to github only to fill a feature request on topic... but found this PR. I believe group avatars should be visible (isn't it their purpose?); it's so common and familiar for ~my friends~ potential users migrating from other popular messengers.

Current UI reminds channels in slack/discord spaces though — is it an actual motivation? In that case I do agree it's a nice feature, but I feel that:

I don't really want my matrix client hiding room avatars from me. And I really like Cinny, wish I could suggest it to my friends as a feature-rich alternative to messaging apps that do not respect privacy.