search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.87k stars 242 forks source link

Placeholders not disappearing in newly upgraded room #124

Closed Empty2k12 closed 2 years ago

Empty2k12 commented 2 years ago

Describe the bug

Screen Shot 2021-09-29 at 16 41 41

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade a room from version 1 to version 6 and then join the new room as a new member. The loading placeholders will never disappear and there's a Uncaught (in promise) TypeError: res.chunk is undefined in the console.

Expected behavior

Cinny recognizes that the end of the timeline has been reached and stops showing the placeholders.

Code

Relevant code-block is https://github.com/ajbura/cinny/blob/2ed4fc9fbfb59e06209397216bac4524f7e41a2e/src/app/organisms/room/RoomViewContent.jsx#L564

Desktop (please complete the following information):

kfiven commented 2 years ago

Hi, I tried to reproduce it, but for me placeholders disappeared after reaching on the top of timeline.

The room I tested on is #hydrogen:matrix.org which recently got upgraded to v9.

Empty2k12 commented 2 years ago

The room this is happening in is #netcup:msrd0.de. Feel free to reproduce.

ajbura commented 2 years ago

Tried to reproduce with account on conduit.rs homeserver and it looks like error is popping up only on conduit based servers.

Tested in room: #netcup:msrd0.de

Error in Cinny: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'map')

Error in Element: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'map')

kfiven commented 2 years ago

@ajbura So is it a Cinny issue or Conduit?

ajbura commented 2 years ago

It's a conduit issue. @kfiven

kfiven commented 2 years ago

Ah, thanks! For reference: https://gitlab.com/famedly/conduit/-/issues/44