Registration disabled, hide register and login form except for OIDC providers

cinnyapp / cinny

Yet another matrix client

https://cinny.in

GNU Affero General Public License v3.0

1.95k stars 250 forks source link

Registration disabled, hide register and login form except for OIDC providers #146

Closed samip5 closed 2 years ago

samip5 commented 3 years ago

Describe the bug

When a Synapse Matrix server has disabled registration, the links should be hidden for registration aswell as hide login input fields but show OIDC authentication provider links.

To Reproduce

Steps to reproduce the behavior:

Deploy Matrix Synapse with OIDC auth only enabled, registration disabled.
Deploy Cinny, change default HS url.
Go to Cinny and see that OIDC provider link has appeared but the login from and registration link is still visiable.

Expected behavior

The login input fields would be hidden and registration link too so only shown would be OIDC/SSO provider login method.

Screenshots

Additional context

Element does it like this:

simonwuelker commented 2 years ago

@ajbura why is this closed? It is not fixed.

ajbura commented 2 years ago

@Wuelle It has been fixed. Why you think it’s not fixed?

simonwuelker commented 2 years ago

Because this Registration link grafik still shows up, despite registration being disabled. Once you click it, you get grafik Two things:

In the first screenshot, the "Dont have an account? Register" link should not appear.
In the second screenshot, the "Already have an account? Login" link should not appear. (This is part of the issue the OP was referring to, so i did not open a new issue and commented on this one instead) I am using v1.6.1

ajbura commented 2 years ago

@Wuelle OP was referring to hide login and registration form not these links.

The reason we’ve kept these links because, a). User can know that registrations are disabled on xyz homeserver when they are on login page. b). And if someone goes to registration page then can come back on login page.

simonwuelker commented 2 years ago

OP was referring to hide login and registration form not these links.

from the original issue:

The login input fields would be hidden and registration link too so only shown would be OIDC/SSO provider login method.

If you already thought about removing the link and decided against it, fair enough. IMO the better way of letting the user know registration is disabled would be by not showing a registration link.