search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.9k stars 246 forks source link

Keyboard scrolling (PageUp) does not work #1551

Open martinxyz opened 10 months ago

martinxyz commented 10 months ago

Describe the bug

Scrolling with PageUp does not work. The text input field scrolls up instead, which has no effect if it does not contain any text.

Reproduction

  1. Focus the input field
  2. Press PageUp

Expected behavior

The timeline should scroll up.

Platform and versions

Happens on app.cinny.in and in the git dev branch. Both in Firefox and Chromium.

Additional context

Removing the wrapping <Scroll> scroll element around the <Editable> in editor.tsx does make the PageUp key event bubble up to listenKeyboard() in hotkey.js, but it does not fix the problem.

This is probably because the input area is a sibling to the timeline (where the scroll bar is) in the DOM, not a parent, so the event cannot bubble up to it.

martinxyz commented 10 months ago

Possibly related to https://github.com/cinnyapp/cinny/issues/1513