cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.98k stars 257 forks source link

spoiler display support #176

Closed deltanedas closed 2 years ago

deltanedas commented 2 years ago

Is your feature request related to a problem? Please describe.

Spoilers with reason using <span data-mx-spoiler> are not supported by cinny. https://spec.matrix.org/v1.1/client-server-api/#spoiler-messages

Describe the solution you'd like

Show a darkened rectangle over spoiler'd text, click to hide it

Describe alternatives you've considered

element blurs it which i don't like for my minesweeper bot command (kinda spoils it doesn't it) element android has a white rectangle which works but is ugly

ShadowJonathan commented 2 years ago

@DeltaNedas Could you change the title to "Spoiler display support"? else people might think this is about supporting creating spoilers

deltanedas commented 2 years ago

done, creating spoilers now in #177 specifically

ajbura commented 2 years ago

It's already done and live in dev.cinny.in. Gonna keep it open until the release.

ShadowJonathan commented 2 years ago

@ajbura does it display reasons for spoilers as well?

ajbura commented 2 years ago

@ShadowJonathan nope.

ShadowJonathan commented 2 years ago

Then I'd recommend leaving this issue open, as showing spoiler reasons is something that matrix also explicitly specs

deltanedas commented 2 years ago

minor issue, but you can't click spoilers to toggle them, instead of only being able to show them when hovered would be cool if spoiler behaviour had a toggle

i basically only care about this for playing minesweeper, so its not too big of a deal

ajbura commented 2 years ago

would be cool if spoiler behaviour had a toggle

Sure, I was just playing around with them and hover looked really cool but I guess that isn't the right way. :D

deltanedas commented 2 years ago

oh no, it is really cool for "normal" use cases

kfiven commented 2 years ago

Closing this as spoilers display now, and created new issue for reason.