search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.98k stars 257 forks source link

Inconsistant margin in settings #1877

Open array-in-a-matrix opened 3 months ago

array-in-a-matrix commented 3 months ago

Describe the bug

i found this little inconsistency in the settings window. left side is 16 pixels (controlled by var(--sp-normal)) but the right side is 8px (controlled by var(--sp-extra-tight)). the class of the tag highlighted is settings-window__cards-wrapper. image

Reproduction

  1. Open settings.

Expected behavior

I expect both sides to be of equal margin either 16 or 8 pixels.

Platform and versions

1. OS: Arch Linux
2. Browser: Firefox 128.0.3 (64-bit)
3. Cinny version: Cinny v4.1.0 (cinny.inamatrix.xyz) running in docker
4. Matrix homeserver: matrix.inamatrix.xyz

Additional context

The right margin seems to be getting overwritten later. https://github.com/cinnyapp/cinny/blob/e68c56b334107862ab2eec5635c11c40c050f00b/src/app/organisms/settings/Settings.scss#L53

ajbura commented 3 months ago

It is because your browser doesn't show scrollbar which result in less ~8px space on right side.

It will go away as we add new design system (folds) because it handles such cases.