cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.87k stars 242 forks source link

[Enhancement] Display emoji-only messages using jumbo emoji #204

Closed Alch-Emi closed 2 years ago

Alch-Emi commented 2 years ago

A lot of chat clients include a feature where messages consisting only emoji (and whitespace) are shown using larger versions of the emoji so that you can see them in more detail. This behavior is present in (at the very least) Discord, Fluffychat, Mattermost, and I'm sure countless others.

A lot of people, myself included, find that this is a handy feature because it makes the emoji immediately more readable by taking advantage of space that wouldn't have been used by text anyway.

Often, this feature is constrained to a certain number of emoji (say, maybe six), and only to messages without any non-whitespace non-emoji characters, to avoid alignment issues.

I'd like to see a feature like this in Cinny. To propose specifics:

The current behavior is simply to display emoji-only messages (and the emoji within) at the same size as they would appear in a standard message.

Cards on the table, I've actually already written an implementation of this here: https://github.com/Alch-Emi/cinny/tree/big-emoji

I foolishly wrote this implementation before reading the Contributing guidelines, which specify that even minor feature changes should go through an issue before a PR is opened, so I'm opening this issue to discuss feature specifics before the PR is opened. I'd also like to make it clear that I absolutely understand if this feature is rejected or needs significant changes from my implementation, and will be willing to make those changes if need be.

Thank you for your feedback!

ajbura commented 2 years ago

Hey, feel free to make a pull request so I can suggest changes and review. Thanks