cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.87k stars 242 forks source link

Keyword notifications are not marked as read automatically. #238

Closed viasux closed 2 years ago

viasux commented 2 years ago

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Set a keyword notification for a chat (in element.)
  2. Get a notification.
  3. Click on the chat with the notification.
  4. It will say "1" forever, unless you manually mark the chat as read.

Expected behavior

I expected that the notification would go away when I clicked on the chat.

Screenshots

Already marked it as read :p

Desktop (please complete the following information):

kfiven commented 2 years ago

This behaviour is not limited to keyword notifications, it happens for all notifications and intentional.

Ajbura explained here why it works like this.

viasux commented 2 years ago

This behaviour is not limited to keyword notifications, it happens for all notifications and intentional.

Ajbura explained here why it works like this.

My issue is different. It doesn't even show where the keyword notification is, so since that's how marking as read works, you can't see how far to scroll (to my knowledge, going off memory)

kfiven commented 2 years ago

Are you looking for something similar for keywords like #235 ?

viasux commented 2 years ago

Are you looking for something similar for keywords like #235 ?

I think keywords function the same as mentions, just cinny doesn't recognize them as mentions, so it never clears the notification.

ajbura commented 2 years ago

It’s intended behaviour as discussed in #184. Marking as read is done when user explicitly does it.

viasux commented 2 years ago

It’s intended behaviour as discussed in #184. Marking as read is done when user explicitly does it.

In my experience, scrolling up to the keyword (which is not displayed or visible where you were mentioned) and then back down to the bottom does not mark the chat as read / the keyword as being seen.

ajbura commented 2 years ago

Mark as read is only done, a) when you click the button or b) scroll to New Messages divider and then come to bottom. Cinny is only aware of new message divider (the place upto which you read last time) because of read receipts but there’s no easy way know where someone got pinged, so any kind of notification is marked read by earlier two ways.

ajbura commented 2 years ago

And even if we get the place of ping, we can only mark room read from last unread to upto that ping which will be wrong because user only read messages below the ping. (Unfortunately that’s how read receipts works).

ajbura commented 2 years ago

Closing as there’s little we can do to solve the issue.