search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.87k stars 242 forks source link

when last room event is user leaving room, departed user is listed as following the conversation [bug] #403

Open iambumblehead opened 2 years ago

iambumblehead commented 2 years ago

Describe the bug

when the last room event is a user leaving room, the departed user is listed as following the conversation

Screenshot from 2022-03-18 22-35-03

Reproduction

  1. leave cinny running with a room selected
  2. wait until a user leaves the room
  3. [bug] see that the user is listed as following the conversation

Expected behavior

users who leave the room should not be listed as following the conversation

Platform and versions

1. OS, any/linux
2. Browser, gnome-web/epiphany 41.3
3. Cinny version v1.8.2

Additional context

No response

kfiven commented 2 years ago

The following conversation is based upon read-receipt of user. So when a user leave or join the room, their read receipt is latest that is why it shows as following the conversation, which is also not wrong because they have seen the messages up-to their leave.

iambumblehead commented 2 years ago

I understand the comment and, politely, still believe this is a bug in some way

ajbura commented 2 years ago

still believe this is a bug in some way

and what is that?

iambumblehead commented 2 years ago

still believe this is a bug in some way

and what is that?

The language is slightly misleading because the "ing" at the end of "following" implies that the person is presently engaged in the "follow" activity. "shalzz followed the conversation" would be more accurate.