search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.98k stars 257 forks source link

App blackout when message contains a wrong closing tag #429

Closed N-R-K closed 2 years ago

N-R-K commented 2 years ago

Describe the bug

On a certain room scrolling up a bit makes cinny black out entirely.

Reproduction

Not sure which message exactly is causing this, but on the console I see the following: Uncaught TypeError: t.href is undefined

Expected behavior

No response

Platform and versions

1. OS GNU/Linux
2. Browser: Firefox 91.4.0
3. Cinny version: dev.cinny.in
4. Homeserver: matrix.org

Additional context

No response

kfiven commented 2 years ago

@N-R-K which room (if it's public)?

N-R-K commented 2 years ago

@kfiven It's public, yes: #gentoo-chatter:matrix.org

N-R-K commented 2 years ago

On a certain room scrolling up a bit makes cinny black out entirely.

Hmm, my wording was bad here. It's not scolling up itself that causes it, but rather scrolling up to a certain msg. Not sure which one, since everything goes blank.

kfiven commented 2 years ago

This was the message causing this:

<a href=https://yewtu.be/watch?v=wl-LeTFM8zo>HOW IT FEELS TO CHEW FIVE GUM GUM GUM YOUR STIMULATION<a/>

Whoever sent it, wrote closing tag wrong <a/> which is causing blackout.

N-R-K commented 2 years ago

Ahh, I see. Thanks for looking into this and fixing the bug.