cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.98k stars 257 forks source link

Configurable time and date format #60

Open hifi opened 3 years ago

hifi commented 3 years ago

Is your feature request related to a problem? Please describe.

Date and time format is hard coded.

Describe the solution you'd like

Currently the defaults seem to be American English which is fine but having the option to at least set other common formats used around the world even without full localization/internationalization would be a welcome addition.

ajbura commented 3 years ago

Date and time format is hard coded.

I see my local time in channel timeline or you talking about something else?

hifi commented 3 years ago

Formatting, 12/24 hour and date style. There should be an override for them.

ajbura commented 3 years ago

Ah, I got you. IMO those should be done with localization/internationalization.

hifi commented 3 years ago

I still want the application to be in English but I'd at least like to have a 24 hour clock and a local date style (dd.mm.yyyy). It's not uncommon to have regional formatting separated from language as people have preferences. That may be obvious but I'm underlining it just in case.

erickhavel commented 3 years ago

Yes please, +1 for 24-hour clock format!

Date format is secondary (to me personally) and it would probably be quick/easy to add a checkbox setting for 12/24 hours compared to thinking through how to deal with various l8n quirks.

Rationale for prioritizing clock over date being that you look at timestamps a lot more than you look at dates (when it comes to chatting).

vwkd commented 3 years ago

Re: https://github.com/ajbura/cinny/issues/60#issuecomment-900241399

Cinny (and every other website) would need to reimplement all internationalization options given by the internationalization APIs such that you can customize it differently for different websites. Internationalization is very hard and puts a huge burden on the website’s shoulders. A website should use the internationalization APIs directly since that is what the APIs are for. Allowing different internationalization for different sites should be a browser setting such that websites don’t have to reimplement custom logic. Granted, no browser seems to be doing that right now. But that might be worth a proposal to your favorite browser.

ashkitten commented 2 years ago

Re: #60 (comment)

Cinny (and every other website) would need to reimplement all internationalization options given by the internationalization APIs such that you can customize it differently for different websites. Internationalization is very hard and puts a huge burden on the website’s shoulders. A website should use the internationalization APIs directly since that is what the APIs are for. Allowing different internationalization for different sites should be a browser setting such that websites don’t have to reimplement custom logic. Granted, no browser seems to be doing that right now. But that might be worth a proposal to your favorite browser.

something i don't think this comment makes very clear is that right now cinny does not use the browser internationalization apis at all, instead opting for a nodejs library that only supports explicit datetime formats. this is why it always uses the american datetime format.

GTcreyon commented 1 year ago

Screenshot_20230313_170027 Would a setting like this be appropriate?

toymil commented 1 year ago

An option to let the user supply date formatting string in addition to predefined ones would be better.

(and please use yyyy-mm-dd not yyyy/mm/dd, as per iso-8601)

WhiteBlackGoose commented 1 year ago

It would be nice to have a full datetime format string (and, if necessary, UI with presets for non-technical people). Xfce4 does it very well, for example

aceArt-GmbH commented 11 months ago

Ah, I got you. IMO those should be done with localization/internationalization.

I implemented it in #1602 (https://github.com/cinnyapp/cinny/pull/1602/commits/ef276389ae8642d07e0257b6570928053b7f6b53#diff-756dcbae1f478ea2a134d93e3d7eab916cf2ff092dd53e0da11b9a207e4bf456R503)

PinguDEV-original commented 2 months ago

+1 from me