Mentions don't tag user - Githubissues

cinnyapp / cinny

Yet another matrix client

https://cinny.in

GNU Affero General Public License v3.0

1.99k stars 258 forks source link

Mentions don't tag user #659

Closed ashfame closed 2 years ago

ashfame commented 2 years ago

Describe the bug

Mention/Tagging users seem broken! Selecting a username from suggestions that are shown only ends up writing their name in input field, that's it.

Screenshot 2022-06-29 at 4 02 03 PM

Screenshot 2022-06-29 at 4 02 12 PM

Screenshot 2022-06-29 at 4 02 19 PM

Reproduction

Type @Ash to trigger suggestions for users you want to select
Choose one of them (either via Tab or mouse click)
The text input simply displays their name now: Ashish and it not a mention pill, hence the user doesn't get notified.

Expected behavior

It should tag the user and notify them.

Platform and versions

MacOS 12.4
Safari browser + Firefox browser
Cinny - running app.cinny.in

Additional context

No response

kfiven commented 2 years ago

User does get notified even if it's not a pill and for the pill there's #19