search

cinnyapp / cinny

Yet another matrix client
https://cinny.in
GNU Affero General Public License v3.0
1.98k stars 257 forks source link

Update to stable APIs #683

Closed thepra closed 2 years ago

thepra commented 2 years ago

Describe the problem

As in this issue I figured that cinny is using and old endpoint: _matrix/client/unstable/org.matrix.msc2432/rooms/:room_id/aliases

meanwhile the stable endpoints are: /_matrix/client/r0/rooms/{roomId}/aliases or /_matrix/client/v3/rooms/{roomId}/aliases

Describe the solution you'd like

Could Cinny update this endpoints? (which make newer matrix server like dendrite to fail the calls given that it doesn't have no more that deprecated endpoint)

Alternatives considered

No response

Additional context

No response

ajbura commented 2 years ago

@thepra This needs to be done in matrix-js-sdk as we are using that.

aaronraimist commented 2 years ago

https://github.com/matrix-org/matrix-js-sdk/pull/2402

kfiven commented 2 years ago

@aaronraimist @thepra https://github.com/cinnyapp/cinny/pull/624 we also use the stable function but this is still in the dev branch and hasn't been released.

kfiven commented 2 years ago

plus it's not just one unstable API call in js-sdk, there are more https://github.com/vector-im/element-web/issues/22839

thepra commented 2 years ago

damn!

kfiven commented 2 years ago

The specific case of room alias API call has now stable API and landed in Cinny 2.1.0, others are not cinny issue but js-sdk's.