Collapsible image thumbnails

cinnyapp / cinny

Yet another matrix client

https://cinny.in

GNU Affero General Public License v3.0

1.98k stars 257 forks source link

Collapsible image thumbnails #916

Open williamkray opened 2 years ago

williamkray commented 2 years ago

Describe the problem

Sometimes a user sends an image that you would prefer not to see, such as:

inappropriate content for the room that hasn't been moderated yet
an overly distracting animated image on loop
when other cinny users prefer to hide thumbnails by default to conserve space in the conversation view, and only open thumbnails when necessary

Describe the solution you'd like

I would like Cinny to support:

a collapsible button next to image or video thumbnails that can be used to shrink the space normally taken by that thumbnail down to a single line of text (presumably the file type and name of the file, such as Image (screenshot.jpg) or Video (my_recording.mp4)
an option in user settings to default all thumbnails to be collapsed

Alternatives considered

there are currently no alternatives to hiding a thumbnail in cinny. alternatives would require using a different client that supports this feature. I do not know of any.

Additional context

No response

williamkray commented 2 years ago

this feature has some overlap with https://github.com/cinnyapp/cinny/issues/679

duarm commented 2 years ago

this would go well with the "open media with default application" instead of embedded players

duarm commented 2 years ago

the caveat from my suggestion is that, for it to work with all video players/image viewers, the files would need to be saved to disk, which is a problem since we're saving private(encrypted) files, cinny needs to clean it up or at least warn the user. mpv can handle piping of images/videos directly to it tho.

williamkray commented 2 years ago

that sounds like a completely different request, and i would suggest opening a separate issue for that so they can be tracked independently.

duarm commented 2 years ago

It is, just bringing up my particular use-case for collapsible image thumbnails

kfiven commented 1 year ago

This is fixed by Low-bandwidth mode, where image don't load unless you click.

williamkray commented 1 year ago

This is fixed by Low-bandwidth mode, where image don't load unless you click.

i disagree, as there is no simple way to re-hide the image once it has been clicked without switching to another room, and doing so re-hides all images again; so if you are looking for a specific image you have to re-click them all, potentially causing you to re-expose the offending image which you then cannot hide again, creating a frustrating cycle.

also, the requested behavior would save screen real-estate, whereas the current low-bandwidth implementation still has large blocks taken up by a non-image as demonstrated in this screenshot: