cio-abcd / variantinterpretation

Collaborative Interpretation-Pipeline workflow based on nf-core pipeline structure
MIT License
7 stars 1 forks source link

Add allele fraction and coverage #19

Closed sci-kai closed 1 year ago

sci-kai commented 1 year ago

Hi, following features are added in this PR:

Also I want to suggest the following defaults:

We could add a feature to extract all FORMAT and INFO fields, but this may be more complicated compared to CSQ fields and also not necessary, as most other Information is very complex and not necessarily needed for the interpreter. If so, he can add it manually through these parameters.

I tested the code manually with my test dataset and several combinations of the parameters.

feiloo commented 1 year ago

I wanted to write out the issues properly and could add a "fix" myself, but wanted your response first :)

sci-kai commented 1 year ago

Hi @feiloo . Thanks for all the helpful comments! I improved my python script and rewrote most of it to increase the separation of concern and readability. I tried to address most of your comments. Can you have a look at it again?