cio-abcd / variantinterpretation

Collaborative Interpretation-Pipeline workflow based on nf-core pipeline structure
MIT License
7 stars 1 forks source link

Improve documentation + code and update nf-core template and modules #32

Closed sci-kai closed 11 months ago

sci-kai commented 11 months ago

This is the final PR for our first release to verison 1.0.0. It adds substantial changes to documentation, updates the nf-core template and modules and making the code more clear. Especially due to the nf-core template and module update the PR is quite huge. So I would kindly ask you to have a quick look into the imrpoved documentation and code improvements as mentioned below:

Documentation:

Code improvements and bug fixes

nf-core updates

feiloo commented 11 months ago

This looks like a multiqc bug, but the "Variant Quality" diagram in the "multiqc_report.html is empty.

Also, everytime the plot is switched via the buttons like "Count SNP, COUNT Transitions, ..." a new unplot is empty and every click on the button creates a new html div element is created but never cleaned up.

sci-kai commented 11 months ago

Thanks for pointing that out. I could reproduce the Issue, but this is a general mutliQC problem that should not affect our release.