Update on amundsen_vocabulary.json

[tratsimbazafy]

• Added sdn_parameter_urn in the attribute of the variable Trans (source: https://vocab.nerc.ac.uk/collection/P01/current/POPTDR01/ )
• suggested a new name for the variable Trans to be consistent

[JessyBarrette]

Thanks @tratsimbazafy for the PR, maybe we can wait to merge this and include all the extra vocabulary to this PR?

[tratsimbazafy]

Yes, we can wait! That PR was meant to be a kind of demo for us. Another should follow. By the way, could you please add Pascal ( @guillotp ) as reviewer especially for this particular json file as he is the one that produces the processed data using this vocabulary ? That way, when he will be boarding the ship, he can follow all the addings I make.

Get Outlook for iOShttps://aka.ms/o0ukef

---

From: Jessy Barrette @.> Sent: Thursday, September 26, 2024 8:55:52 AM To: cioos-siooc/ocean-data-parser @.> Cc: Tahiana Ratsimbazafy @.>; Mention @.> Subject: Re: [cioos-siooc/ocean-data-parser] Update on amundsen_vocabulary.json (PR #114)

Thanks @tratsimbazafyhttps://github.com/tratsimbazafy for the PR, maybe we can wait to merge this and include all the extra vocabulary to this PR?

— Reply to this email directly, view it on GitHubhttps://github.com/cioos-siooc/ocean-data-parser/pull/114#issuecomment-2376876148, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFBY5VSDCKURFM2L7O42FQLZYP75RAVCNFSM6AAAAABO3GHSUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWHA3TMMJUHA. You are receiving this because you were mentioned.Message ID: @.***>

[JessyBarrette]

Certainement!

[JessyBarrette]

@TahianaRatsimbazafy you can populate for now maybe just the sdn_parameter_urn and ignore sdn_parameter_name which we can automatically add while using the other attribute.

[tratsimbazafy]

@JessyBarrette , sounds good!! When I find the official code for the unit ( sdn_uom_urn), I will add them along the sdn_parameter_urn as well if needed.

[JessyBarrette]

sounds good to me!

[JessyBarrette]

@guillotp