ciotlosm / lovelace-thermostat-dark-card

🌡 Thermostat card with a round and black feel to it
MIT License
734 stars 187 forks source link

toggle / ecobee issue #287

Open ischorr opened 3 years ago

ischorr commented 3 years ago

Checklist:

Release with the issue: 0.0.5

Last working release (if known): n/a

Description of problem:

Great to see a new update, couple issues seen with the new toggle feature, though. In my case, with an ecobee setup with fan, heat, cool, auto support:

ischorr commented 3 years ago

Just tagging @swingerman as an FYI

swingerman commented 3 years ago

Just tagging @swingerman as an FYI

Thanks for finding this @ischorr

Here is the feedback you should experience if the card works properly:

https://user-images.githubusercontent.com/7681395/137441224-aeac5b6e-9efa-4dcb-96e2-6c968383de8b.mov

Off state: image

I think I might need to review if that climate integration the card controls actually supports off state and hide the button if not. But I need to investigate first.

jessiewestlake commented 3 years ago

Just tagging @swingerman as an FYI

Thanks for finding this @ischorr

Here is the feedback you should experience if the card works properly:

Screen.Recording.2021-10-15.at.09.10.00.mov

Off state: image

I think I might need to review if that climate integration the card controls actually supports off state and hide the button if not. But I need to investigate first.

I notice the dual range, heat/cool mode cards do not show the temperature on the hash marks unless it is actively running to heat or cool. I see this even in your video, is it intentional?

jessiewestlake commented 3 years ago

Checklist:

  • [ x I updated to the latest version available
  • [x] I cleared the cache of my browser

Release with the issue: 0.0.5

Last working release (if known): n/a

Description of problem:

Great to see a new update, couple issues seen with the new toggle feature, though. In my case, with an ecobee setup with fan, heat, cool, auto support:

  • Toggle off works, but there's no visual indication to the user that the input has been received. There's no immediate UI response. If there's a lag for the integration to detect a state change, that might confuse people to think nothing happened, and try to toggle again. Although even if there's a state change, there still might not be an indicator to the user.
  • Toggle on does not work. Nothing seems to happen - system stays in off state indefinitely.

    • Ability to set cool/heat/fan mode would work around that, but hasn't been added yet

This happens to me too, except it’s because the thermostat will go from idle to off, but when you set it back to heat/cool or heat or cool, it stays in off mode until the temperature triggers an action (either heat or cool). So it’s not the fault of the integration.

swingerman commented 3 years ago

Just tagging @swingerman as an FYI

Thanks for finding this @ischorr

Here is the feedback you should experience if the card works properly:

Screen.Recording.2021-10-15.at.09.10.00.mov

Off state: image

I think I might need to review if that climate integration the card controls actually supports off state and hide the button if not. But I need to investigate first.

I notice the dual range, heat/cool mode cards do not show the temperature on the hash marks unless it is actively running to heat or cool. I see this even in your video, is it intentional?

I guess yes, I never worked on that part though.

jeffgoh commented 2 years ago

I can turn off, but I cannot turn on using the "power button" - to turn on, I need to click on the temperature and click either the up or down chevron - so close, yet so far. Any hints how to fix?

swingerman commented 2 years ago

I can turn off, but I cannot turn on using the "power button" - to turn on, I need to click on the temperature and click either the up or down chevron - so close, yet so far. Any hints how to fix?

The owners of this repo don't seem to have time to review any PRs or issues, so I don't know how to help here. I would spend my free time fixing any issues but it's no point if no one will review them and merge them.

I applied the changes to my forked repo here: https://github.com/swingerman/lovelace-thermostat-dark-card feel free to use it instead