cip / Wikipedia

Wikipedia
GNU General Public License v2.0
2 stars 1 forks source link

Menu and header position/content scrolling #1

Open cip opened 12 years ago

cip commented 12 years ago

Wikipedia app has scrollable content and two fixed elements: header at top, and menu at bottom of screen.

On cordova-qt (tested on Nokia N8) this does not work as expected:

With "goodscroll" implementation (Default in wikipedia 1.1)

Elements positioned correctly. Scrolling only possible via scrollbar, no kinetic scrolling possible.

with iscroll

Used in wikipedia 1.1 for ios 4.2

Elements (still) positioned correctly Scrolling not working at all in simulator, incorrectly on device. (Behaving as if content connected with rubber band to header)

with "badscroll"

Enabled via

chrome.addPlatformInitializer(function() {
//        $('html').removeClass('goodscroll').addClass('badscroll');
});

Elements scroll with content :( Kinetic scrolling works

Qtwebkit appearantly not supporting css position:fixed. Note that badscroll originally used for Android 2.2/2.3 only. As menu currently used for Qt is from IOS version, badscroll not implemented for menu. (That is position:fixed not set). Thus issue only visible with header, menu scrolling of is expected as position:fixed not set.

cip commented 12 years ago

Proposal to fix this:

  1. Implement menu native, using qml toolbar. (With plugin as used in android version) Besides solving this issue, it should also look nicer.
  2. Header: Scrolling it may actually be anyway nicer. Both nokia browser and opera browser also scroll the address bar. On loading a new page it is shown again. Related https://bugzilla.wikimedia.org/show_bug.cgi?id=33881, and https://github.com/brion/Wikipedia/commits/absolute (https://bugzilla.wikimedia.org/show_bug.cgi?id=32917)