Closed TheCell closed 1 year ago
The main version number of ngx-filesave has always been consistent with that of angular.
Starting from angular 15.0, the rxjs version has been updated to 7.8.
And rxjs has beed deprecated 'rxjs/operators' since 7.2. The above are some historical factors, and it is reasonable to use 'rxjs' instead of 'rxjs/operators'.
Thank you very much for your answer. I think this issue can be closed, it's a mistake on our part to not have upgraded rxjs when upgrading Angular until now!
We are using this package in our Angular 15 application and during a regular maintenance task we updated the package from 15.0.0 to 15.0.1. However, the version bump results in errors:
I suspect it has to do with this commit b2978bd86bac9f8249fbbc12525de06916612f3a.
I tried to setup a new angular project, import ngx-filesaver 15.0.1 and rxjs takeuntil directly but it does not result in the error on its own. But If I manually set the rxjs version of the project to ^6.6.7
and then using the older import for rxjs in my component, it will fail with the same error message.
Is the newly added imports to
lib/src/filesaver.directive.ts
a breaking change? In version 6.6.7 the 'takeUntil' was still imported like this:import { takeUntil } from 'rxjs/operators';
(which we imported from there) Might be helpful.