search

cipherdevgroup / cipher-theme-config

Grunt configuration for Cipher themes
MIT License
8 stars 4 forks source link

consider using package vs pkg #7

Closed ctalkington closed 8 years ago

ctalkington commented 8 years ago

this is something I came across digging into another issue I was having.

https://github.com/talkingtontech/wp-theme-config/commit/4d9a0593e575a596dbe1ec37ad4367986d15f99f

essentially load-grunt-config does the initial package.json read for you so by using and updating its var you avoid extra fs read off the bat.

robneu commented 8 years ago

That looks :+1: to me. I'll make that change unless you want to send a PR for it.

robneu commented 8 years ago

@ctalkington This is a little off-topic, but how do you test your config locally? I've tried using npm-link in the past but couldn't get it working so I wind up just pushing crap to the repo even if it's not fully tested.

ctalkington commented 8 years ago

sadly, i haven't worked anything too scientific, usually i make changes based on something i noticed in consuming project so ill edit its local node_modules and copy that dir back to config repo once im happy. in other words, trial and error.

i have debated adding a travis to the config repo that runs a sample or something.

ctalkington commented 8 years ago

you also can remove:

https://github.com/wpsitecare/alpha/blob/685acbfadd4d2725eef19bc0df43320521f33f00/gruntfile.js#L8

now as package is auto set and your just updating with readpkg

robneu commented 8 years ago

:+1: Looks like this is all good!