Everything still tied to 60FPS (that i could find)

[yumtako]

All tests done with TargetFrameRate set to 120. also, thank you so, so much for making this. i've wanted this type of thing for eons.

Stuff that is definitely broken:

• First Person swimming is entirely broken and actually makes the game unpleasant to play at times (mainly in the area with spotlights after The Pain fight)
• Viewbobbing while swimming (third and first person)
• Leaning is too slow/weighty
• Crawling (spinning around in place is too fast; viewbobbing in first person crawling areas)
• Walking in the box. if you don't notice it, try moving the camera up and down while boxwalking.
• Survival Viewer (cycling through options, pinning snake around in the cure menu)
• Camera animation for going into 1st person
• Weapon switching (a side effect of this is that clicking down on LT/RT to quick reload/equip items has more specific timing, and at even higher fps could be entirely impossible)
• Snake throws food too far (i have two ideas why: due to the lack of pressure sensitive buttons, the longer you hold the attack button the further the food is thrown, this could be messed up by the fps unlock OR it could simply be that food physics is capped with fps)
• Falling down (pressing A while hanging/jumping from ledges) feels wrong. it seems too slow, oddly enough. something about the fps or maybe an attempted fix for it makes the fall speed ramp up too slowly, and hopping from ledges makes you jump into the ledge and then teleport to the ground below. EDIT: also it seems that grabbing onto a lower ledge while following can bounce you upward at higher fps or in certain scenarios
• Codec/radio (camera switching when pressing down on the left stick; cycling through codec/radio contacts; character info text while calling someone)
• The Sorrow pushing you back while first person swimming (pushes you back too far due to fps)
• OG Snake Eater (fixed/click down on right stick/R3) cam. try using the stick to move it in any direction.
• In fact, generally all fixed cam angles are very jerk-ey. kinda? they switch between angles too fast.

Stuff that might be broken:

• fish and certain water effects MIGHT be still tied to fps??? (mainly the effects in tikhogornyj/area after The Sorrow seem wrong, though again it may have always been like this)
• grass seems overexaggerated. may have always been like this, though.
• Animations for switching between areas seems glitchy/slightly desynced. could cause issues in certain areas at certain fps.
• aiming in first person (with gun) seems to be slightly faster than it should be. feels too snappy, i guess maybe something tied to the floatiness/slowdown of the aiming (time from when you stop holding the trigger to when the aim stops moving)

the stuff below was tested with TargetFrameRate set to 100

Bike segment/shagohod issues:

• the bike took lessons from Sonic the Hedgehog
• the shagohod took acrobatics classes before the bridge scene (it completely messes up at higher than 100 fps, making the bridge scene a softlock)
• the shagohod is also affected by fps in the boss fight for it; shooting the treads lifts it up way too high

Stuff found by Strafe:

Certain guards are off-sync, especially Cobra Unit

[cipherxof]

You mentioned on discord that you set your framerate target to 120fps but you capped your game at 90fps and would dip below that. How many of these issues still apply with a proper framerate target set?

[yumtako]

You mentioned on discord that you set your framerate target to 120fps but you capped your game at 90fps and would dip below that. How many of these issues still apply with a proper framerate target set?

That only happened with the bike scene, and i retested afterward with a proper frametarget set (set to 90) all of the issues that i've mentioned still occur, except for the gun animation slowdown, which i've removed from the issue list.

[emoose]

BTW it seems the games still have some remnants of 50Hz/60Hz speed switching from the X360 version built into it, eg things like:

That GameIs50Hz function (0x140001E40 in MGS3 1.0.0) probably would have been great to look through xrefs for to get an idea of what should be changed based on framerate, sadly in MC that func was gutted and replaced with return false, and seems their compiler folded all the same return false functions together, so now there's 500+ xrefs to that which are mostly not speed related :(

Maybe would be possible to go through each of them and mark down things that do look related, would probably take some effort though. (alternately the function for that in X360 should have far less refs since it was left intact there, could be worth looking at to get an idea of things - iirc to find it in X360 you can look for what calls VdQueryVideoMode)

Maybe you noticed this already though, but felt it was worth bringing up just in case.

[cipherxof]

BTW it seems the games still have some remnants of 50Hz/60Hz speed switching from the X360 version built into it, eg things like:

That GameIs50Hz function (0x140001E40 in MGS3 1.0.0) probably would have been great to look through xrefs for to get an idea of what should be changed based on framerate, sadly in MC that func was gutted and replaced with return false, and seems their compiler folded all the same return false functions together, so now there's 500+ xrefs to that which are mostly not speed related :(

Maybe would be possible to go through each of them and mark down things that do look related, would probably take some effort though. (alternately the function for that in X360 should have far less refs since it was left intact there, could be worth looking at to get an idea of things - iirc to find it in X360 you can look for what calls VdQueryVideoMode)

Maybe you noticed this already though, but felt it was worth bringing up just in case.

I did notice this, yes. I had actually hooked the function and forced it to return true (while also ignoring the specific calls that crashed), and I didn't see any difference in FPS/gamespeed. I may have been doing the hook too late though.

In the X360 version, when the refresh rate is at 50hz GV_TimeBase is set to 6 (default is 5, so 20% higher). The problem with higher refresh rates is that we can't divide the time base evenly. For example, 120hz would be 2.5, but GV_TimeBase is an integer (which is typecasted to a float in many places...). The X360 version is a good place to look though to find the problematic areas, so thanks for reminding me, but there are over 100 xrefs to go through :(