search

cipherxof / wc3-ts-template

A template to code in TypeScript for Warcraft III maps.
MIT License
52 stars 14 forks source link

Peer dependency issue when using latest package version #20

Open bertman12 opened 11 months ago

bertman12 commented 11 months ago

`
"typescript": "5.0.4", "typescript-to-lua": "^1.15.1",

` Latest version of typescript-to-lua uses typescript 5.2.2, however we use 5.0.4 causing peer dependency issue.

Can we change to this? "typescript-to-lua": "1.15.1",

bertman12 commented 8 months ago

Can I make a PR to implement the change? I think I need permissions to create a branch and then create a PR.

peer dependency error

cipherxof commented 8 months ago

You can yeah. We also need to remove package-lock.json from gitignore.

bertman12 commented 8 months ago

Alright, still getting permission denied.

cipherxof commented 8 months ago

Alright, still getting permission denied. git-permission-denied

You need to fork the repo and make the changes on your own branch, then create a pull request.

bertman12 commented 8 months ago

PR created