search

ciphs / cryptocurrency

CIPHS© Cryptocurrency & Consensus Code
http://ciphs.org
MIT License
2 stars 2 forks source link

Improvement of functions CIP#2 #10

Open ciphs opened 6 years ago

ciphs commented 6 years ago

Hi. Regarding Ciphs current code. There are few issue that need to be carry forward in CIP#2 coming soon. As listed below:

  1. Most of exchange are accepting ERC20 only token, which limit the liquidation process within circulation. Have been into contact with few exchange and they admitted that ERC223 are better. Not much an issue to us as ERC223 secure CIPHS.

Solution: Let's ban these ERC20 only exchange :+1: kidding

  1. Manual handling of tokenFallback function. Causing issue with ERC223 exchange even after manually approve allowance. Tx are reverted or ends up with error such bad jump destination and out of gas.

Solution: @dexaran @billiegate @nidscom

I reserve below here for additional issue. Regards.