search

ciplogic / fheroes2enh

Free Heroes 2 - Enhanced
Other
134 stars 19 forks source link

Fix override compilation warning #28

Closed ihhub closed 5 years ago

ihhub commented 5 years ago

While compiling on MacOS we see a lot of overrides a member function but is not marked 'override' [-Winconsistent-missing-override] warnings which is bad to have at first place as the project is not big.

ciplogic commented 5 years ago

I tried to reduce the overrides, but sometimes (as the code is not mine) the call is wrongly not an override, but a separate method. I remember around Army/Monster relation.

If you make a PR, make sure you don't regress the code.