search

cirKITers / mind-the-qapp

An Application for Visualizing the Crux in Quantum Machine Learning
MIT License
0 stars 0 forks source link

[BUG] Cleanup Instructor #21

Open stroblme opened 4 months ago

stroblme commented 4 months ago

After discovering a bug in #20, I think that the instructor deserves some further cleanup especially regarding unused initialization (e.g. optimizer not needed if we don't want to train the model). This requires checking every usage of the instructor object and making sure that we use a common api (e.g. not using the underlying model attributes if those are propagated by the instructor.

majafranz commented 1 month ago

This should probably also be resolved, when integrating the qml-essentials with an additional cleanup. See #25