search

circe / circe-yaml

YAML parser for circe using SnakeYAML
Apache License 2.0
141 stars 51 forks source link

Added indentWithIndicator to Printer #398

Closed KostadinAlmishev closed 4 months ago

KostadinAlmishev commented 1 year ago

Fixes #130

To indent entire array when indicatorIndent != 0, to printer should be passed indentWithIndicator = true

zarthross commented 1 year ago

Thanks for the submission, but it looks that change won't be binary compatible.... What needs to be done is deprecating Config and the current make function and creating a new ConfigBuilder, similar to what Ember does here: https://github.com/http4s/http4s/blob/00fcd90fcd26259026908dd4e1bff853432ac3f0/ember-client/shared/src/main/scala/org/http4s/ember/client/EmberClientBuilder.scala#L44. With the builder pattern we'll be able to add options compatibly going forward!

hamnis commented 4 months ago

closing in favour of #406