moving to fork/PR workflow

circify / compiler

Superseded by https://github.com/circify/circ

https://github.com/circify/circ

5 stars 2 forks source link

moving to fork/PR workflow #15

Closed kwantam closed 3 years ago

kwantam commented 4 years ago

Hi folks (especially @mlfbrown @alex-ozdemir):

As we start getting more cooks in this kitchen, I think we'll probably end up happier if we limit write access to this repo to the bare minimum (I'd prefer just Alex and Fraser), have everyone else work in forks, and use PRs for everything.

If there are reasons not to do this, we should discuss them here. We should also figure out a timeline for making the switch, if indeed we do.

Thoughts?

alex-ozdemir commented 4 years ago

I certainly support the fork/PR/code-review workflow.

Limiting write access to two people might eventually create a bit of a bottleneck, but probably would be fine for now.

CVC4 uses a system where everyone has write access, but the master branch has extra protections (e.g., master PRs need an an approving review before merging). I'll look at how that's setup and report back here with the details, for our consideration.

sga001 commented 3 years ago

Seems like we already did this.