circleci / bond

spying for tests
127 stars 28 forks source link

made this project cljc so it can be used in cljs projects #14

Closed JustinC474 closed 8 years ago

JustinC474 commented 8 years ago

So this is kind of the definition of a snowball pr.

The original intent was to move this from being .clj to .cljc so it can be utilized in both clj and cljs projects. I moved everything to cljc which unfortunately broke the tests because we were using lein cloverage, which does not support cljc (even though there is a pr to support it currently open - https://github.com/lshift/cloverage/pull/93).

One I removed lein cloverage and realized no tests were running, it seems that lein test-out was not properly running the tests (which I confirmed by running known bad code with lein test here (https://circleci.com/gh/circleci/bond/52) and lein test-out here (https://circleci.com/gh/circleci/bond/53), so I also removed that.

Also codecov wasn't working without lein cloverage, so I removed that.

After all this I cleaned up virtualenv.txt since it was for the codecov, and then also deleted the circle.yml since everything that we need now (basically lein deps and lein test) will be inferred by circle.

Also I'm bumping the version.

I've added an issue to add all the code coverage stuff back once the pr on lein cloverage is merged. (https://github.com/circleci/bond/issues/15)

j0ni commented 8 years ago

igyb

travis commented 8 years ago

lgtm