dcarley commented 3 years ago

So that we don't need to find credentials and remember how to release changes manually. Git tags are used to trigger publishing so that we don't re-publish over existing versions every time we merge to master. It also means that we're more likely to remember to tag and don't need to add any logic or credentials for the workflow to create tags.

An alternative would have been to use the build number as a patch version, but it's unwieldy for both for users and for us to maintain the versions in README.md and CHANGELOG.md.

The CLOJARS_USERNAME and CLOJARS_TOKEN environment variables have been added to the project. At the moment they belong to an individual but we'll move them to a machine user later. The project already has "build forks" and "pass secrets to fork builds" disabled, which will prevent leaking these credentials.

Depends on #53 and #54.

calvis commented 3 years ago

tests failed because this is using an ancient version of clojure [org.clojure/clojure "1.7.0"]

aterweele commented 3 years ago

tests failed because this is using an ancient version of clojure [org.clojure/clojure "1.7.0"]

@calvis I have a fix for that in 8946a91d59f606ff6b9ecb3aa7893a81b6311c1c, so merging #51 and rebasing this PR ought to fix that

calvis commented 3 years ago

can we not update the Clojure version, instead?

dcarley commented 3 years ago

can we not update the Clojure version, instead?

There be dragons, it turns out. I've raised #53 and #54 to take another approach. I'll rebase this PR if they're merged.

aterweele commented 3 years ago

I'm going to bow out of this and leave it up to y'all what should be done here. Thanks for your work to cut a release!

codecov[bot] commented 3 years ago

Codecov Report

Merging #52 (de294c2) into BACKPLANE-1080/upgrade-deps (2fe9055) will not change coverage. The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           BACKPLANE-1080/upgrade-deps      #52   +/-   ##
============================================================
  Coverage                        98.76%   98.76%           
============================================================
  Files                                2        2           
  Lines                               81       81           
  Branches                             1        1           
============================================================
  Hits                                80       80           
  Partials                             1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fe9055...de294c2. Read the comment docs.

dcarley commented 3 years ago

I've rebased this to no longer use build number for patch versions, added a CHANGELOG, and bumped for version 0.5.0

circleci / bond

Release version 0.5.0 with automation #52

Codecov Report