circleci / bond

spying for tests
128 stars 28 forks source link

Remove support for ClojureScript #53

Closed dcarley closed 3 years ago

dcarley commented 3 years ago

We no longer actively use ClojureScript within CircleCI and supporting it in this project has become a non-trivial amount of effort. In particular, the behaviour of ns-publics is different between Clojure and ClojureScript, after upgrading both:

Which causes this exception that can't be easily satisfied for both:

Caused by: java.lang.AssertionError: Assert failed: Argument to ns-publics must be a quoted symbol

I can only find one ClojureScript project that uses a recent version of bond. We'll release this change in a new version to indicate the break in compatibility:

calvis commented 3 years ago

the behaviour of ns-publics is different between Clojure and ClojureScript, after upgrading both Which causes this exception that can't be easily satisfied for both

can you explain why we can't get around this with a language switch statement? i'm not sure what we're considering an "easy" solution

dcarley commented 3 years ago

Being discussed in https://circleci.slack.com/archives/C2B6H0E65/p1612779638045200 which I will summarise back here afterwards.