dcarley commented 3 years ago

In order to allow publish to run on a tag. Previously the tag I pushed resulted in "no workflow" because of: (https://circleci.com/docs/2.0/configuration-reference/#tags)

Additionally, if a job requires any other jobs (directly or indirectly), you must specify tag filters for those jobs.

I've deleted the 0.5.0 tag that I previously created and will recreate it after this change. This isn't great form, as tags should be immutable, but it won't have been used for anything yet and doesn't warrant bumping the version because we failed to release it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (354e355) into master (877d169) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   98.76%   98.76%           
=======================================
  Files           2        2           
  Lines          81       81           
  Branches        1        1           
=======================================
  Hits           80       80           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 877d169...354e355. Read the comment docs.

dcarley commented 3 years ago

I talked to the Pipelines team about improving the feedback for this scenario: internal Slack thread

circleci / bond

ci: Add tag filter to test #55

Codecov Report