search

circleci / rollcage

A Clojure client for Rollbar
Eclipse Public License 1.0
50 stars 28 forks source link

Set the language type to Java #25

Closed marcomorain closed 6 years ago

marcomorain commented 6 years ago

This will force Rollbar to render callstacks in the typical Java order.

codecov[bot] commented 6 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files           2        2           
  Lines         145      145           
  Branches        3        3           
=======================================
  Hits          141      141           
  Misses          1        1           
  Partials        3        3
Impacted Files Coverage Δ
src/circleci/rollcage/core.clj 97.05% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22e4961...2a45f5e. Read the comment docs.

gordonsyme commented 6 years ago

Can you go into why we want to swap the callstack order?

brianr commented 6 years ago

Hey, Rollbar staff here... this will actually break some other language-specific customizations we have for Clojure.

@marcomorain Let me fix the trace direction on our side. I'll get that out shortly.

brianr commented 6 years ago

Following up - the change on the Rollbar side is live:

gordonsyme commented 6 years ago

Thanks for the quick response and updates @brianr