Closed marcomorain closed 6 years ago
Merging #25 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 2 2
Lines 145 145
Branches 3 3
=======================================
Hits 141 141
Misses 1 1
Partials 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/circleci/rollcage/core.clj | 97.05% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 22e4961...2a45f5e. Read the comment docs.
Can you go into why we want to swap the callstack order?
Hey, Rollbar staff here... this will actually break some other language-specific customizations we have for Clojure.
@marcomorain Let me fix the trace direction on our side. I'll get that out shortly.
Following up - the change on the Rollbar side is live:
language
is clojure
(case-insensitive), then the stack trace will be shown in the 'most recent call first' directionThanks for the quick response and updates @brianr
This will force Rollbar to render callstacks in the typical Java order.